Skip to content

Pr 3056 #3149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
danpovey merged 16 commits into from
Apr 3, 2019
Merged

Pr 3056 #3149

danpovey merged 16 commits into from
Apr 3, 2019

Conversation

@jyhnnhyj
Copy link
Contributor

@jyhnnhyj jyhnnhyj commented Mar 20, 2019

No description provided.

@jyhnnhyj jyhnnhyj mentioned this pull request Mar 20, 2019
Closed
danpovey
danpovey reviewed Mar 20, 2019
View reviewed changes
danpovey
danpovey reviewed Mar 20, 2019
View reviewed changes
danpovey
danpovey reviewed Mar 20, 2019
View reviewed changes
danpovey
danpovey reviewed Mar 20, 2019
View reviewed changes
@jyhnnhyj
Copy link
Contributor Author

jyhnnhyj commented Mar 29, 2019

all done - @danpovey please have a look and kindly let me know if all is okay and what's next

danpovey
danpovey reviewed Mar 29, 2019
View reviewed changes
egs/tedlium/s5_r3/local/chain/run_tdnnf.sh
@@ -1 +1 @@
tuning/run_tdnn_1b.sh No newline at end of file
tuning/run_tdnn_1c.sh No newline at end of file
Copy link
Contributor

@danpovey danpovey Mar 29, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

call this link run_tdnn.sh, which is the standard name we use.

@danpovey
Copy link
Contributor

danpovey commented Mar 29, 2019

also can you please rebase against the master, if you know how... the git diff has things that shouldn't be in there (probably a github error).

@jyhnnhyj
Copy link
Contributor Author

jyhnnhyj commented Mar 31, 2019

I merged with master already...
which git diff you mean? I can double check those file
for examples changes related to compare_wer_general are done by me to make it find the WER patterns in the scoring results

@danpovey
Copy link
Contributor

danpovey commented Mar 31, 2019

The soft link run_tdnnf.sh should be called run_tdnn.sh. rebase is not the same as merge... look it up.

@jyhnnhyj
Copy link
Contributor Author

jyhnnhyj commented Apr 3, 2019

So, I renamed the file
rebased with master and pushed again (with -f)
could you check and confirm now?

@danpovey danpovey merged commit ffbe16b into kaldi-asr:master Apr 3, 2019
@danpovey
Copy link
Contributor

danpovey commented Apr 3, 2019

thanks!

@jyhnnhyj jyhnnhyj deleted the pr-3056 branch April 3, 2019 16:20
@jyhnnhyj
Copy link
Contributor Author

jyhnnhyj commented Apr 3, 2019

Thanks a lot Dan for your help and patience as well!
so what's next and where can I help more?

@danpovey
Copy link
Contributor

danpovey commented Apr 3, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@danpovey danpovey danpovey left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jyhnnhyj @danpovey @vimalmanohar